Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages update #825

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Apr 9, 2024

No description provided.

@ehelms
Copy link
Member Author

ehelms commented Apr 9, 2024

Proposing two changes here that are related:

  1. Allow passing --assumeyes to packages update to not prompt the user when doing an update of all packages
  2. Add a --cache option that allows packages update to download but not install packages, the idea here is to provide users with two steps that they can orchestrate independently -- downloading of updates and application of the updates.

These two changes come from https://bugzilla.redhat.com/show_bug.cgi?id=2042899#c9

@evgeni
Copy link
Member

evgeni commented Apr 11, 2024

I'm cool with the changes (minus the few style comments I had) and you offended the 👮‍♂️

@ehelms
Copy link
Member Author

ehelms commented Apr 11, 2024

Yea, for some reason Rubocop is throwing errors that are not showing up locally and it's really confusing.

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK once the 👮‍♂️ is happy

@ehelms ehelms merged commit 2c63362 into theforeman:master Apr 12, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants